Fix infinity-loader not updating model when infinity reached #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelSumner
approved these changes
Apr 28, 2025
Contributor
There was a problem hiding this comment.
I don't know what else to suggest but I can at least help you get unblocked with this workaround if that's useful.
Adding for clarity: obviously we don't want to use {{did-update}} but it's already being used in this addon, so there's no sense in keeping you blocked while the addon is updated. I'm going to file an issue so this addon can be evaluated for further updates or maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
In our application we allow changing filters that are passed to the infinity model, so we create a new infinity model. However, when the current model has reached infinity, updating the infinity model does not update within the infinity loader, so the new model does not load more pages.
I added a test that reflects this, and fixed it by adding an empty div when not shown, to host the
{{did-update}}. Not an ideal solution, so let me know if there are other solutions 👍